[alsa-devel] [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124

Tomoya MORINAGA tomoya.rohm at gmail.com
Thu Mar 8 03:24:36 CET 2012

On Wed, Mar 7, 2012 at 8:48 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
>> If possible, I want to use framework features. However, I judged it is
>> not possible.
>> Let me confirm again.
>> As I said before, all ML26124 registers need to be accessed by
>> different address when read and write.
>> Like below
>> R       W
>> $00h $01h Sampling setting
>> $02h $03h PLL setting
>> ...
>> Even so, can I use framework features ?
> No, in which case (to repeat what I said previously) you need to make
> the code *much* clearer so the reader can understand what it is doing
> and why it's having to open code this stuff.

I understand you agree to use ml26124_update_bits(), right ?
If so, do you mean that I should just add explanation (like as I
explained before)
why the function() is necessary to above prototype of ml26124_update_bits() ?

ROHM Co., Ltd.

More information about the Alsa-devel mailing list