[alsa-devel] [PATCH] ASoC: dapm: Add API call to query valid DAPM paths.

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Mar 7 20:15:48 CET 2012

On Wed, Mar 07, 2012 at 05:55:52PM +0000, Liam Girdwood wrote:

> +struct snd_soc_dapm_widget_list;

I might be blind but I think the hunk that actually declares the widget
list got dropped from the header...  probably in some other part of the
series you haven't pushed out yet?

> +		dev_vdbg(widget->dapm->dev," %c : %s -> %s -> %s\n",
> +			path->sink && path->connect ? '*' : ' ',
> +			widget->name, path->name, path->sink->name);
> +

This and the input user look like good candidates for a tracepoint, it's
probably pretty useful to have them around and more accessible than vdbg
is.  It's the sort of information people often look for, and it's real
time unlike the debugfs picture which isn't capturing stuff when DAPM is
looking at it.

> +	dapm_reset(card);

This function isn't in mainline, another patch series reordering thing I
expect.  It does also look like we need some locking somewhere along the
line here (even if the only thing here is a big scary comment saying the
relevant locks need to be held).

> +	dev_dbg(dai->dev, "%s: found %d paths\n",
> +			stream ? "capture" : "playback", paths);

Tracepoint again?  Much less clear for this one.  I do think we should
be dumping the stats we've been collecting for the neighbour walks, very
useful if performance blows up again.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120307/d8145b93/attachment-0001.sig 

More information about the Alsa-devel mailing list