[alsa-devel] [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Mar 6 13:12:22 CET 2012

On Tue, Mar 06, 2012 at 07:49:16PM +0900, Tomoya MORINAGA wrote:
> On Tue, Mar 06, 2012 19:00 Mark Brown <broonie at opensource.wolfsonmicro.com>:

> > This is not what the above prototype says, the above prototype has only
> > one register in it.  You need to make this *much* clearer for the
> > registers it's affecting.

> Sorry, I couldn't understand your saying / concern.
> Do you mean I shouldn't use ml26124_update_bits() but snd_soc_update_bits() ?

Ideally you should be using the framework features.  If there is some
reason why you can't you need to make it much clearer what the reason
is so people reading the code can understand.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120306/45e049eb/attachment-0001.sig 

More information about the Alsa-devel mailing list