[alsa-devel] [PATCH v2 11/17] ASoC: fsl: create fsl_utils to accommodate the common functions

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Mar 5 17:15:20 CET 2012

On Mon, Mar 05, 2012 at 09:48:53AM -0600, Timur Tabi wrote:
> Mark Brown wrote:

> > This doesn't seem at all Freescale specific, it should be a generic
> > helper, and in fact there already is one - the machine driver can set
> > codec_of_node in the card structure to point to the device node and then
> > the core should figure out binding to the device for you.  If it doesn't
> > we should fix the core.

> Can we do that in another patch set, so that it doesn't hold up Shawn's
> work?  All this patch does is move the code from one file to another, so
> it's not like he's adding a feature incorrectly.

Well, it shouldn't be much effort - instead of removing the code just
delete it mostly - and there's other issues that need to be looked at
anyway.  There's also the arch/arm stuff that needs review...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120305/614b0279/attachment.sig 

More information about the Alsa-devel mailing list