[alsa-devel] [PATCH] ALSA: snd-usb-caiaq: initialize card pointer
tiwai at suse.de
Wed Jun 27 12:30:26 CEST 2012
At Mon, 18 Jun 2012 21:16:31 +0200,
Daniel Mack wrote:
> Fixes the following warning:
> CC [M] sound/usb/caiaq/device.o
> sound/usb/caiaq/device.c: In function ‘snd_probe’:
> sound/usb/caiaq/device.c:500:16: warning: ‘card’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> Signed-off-by: Daniel Mack <zonque at gmail.com>
> sound/usb/caiaq/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c
> index 64aed43..7da0d0a 100644
> --- a/sound/usb/caiaq/device.c
> +++ b/sound/usb/caiaq/device.c
> @@ -485,7 +485,7 @@ static int __devinit snd_probe(struct usb_interface *intf,
> const struct usb_device_id *id)
> int ret;
> - struct snd_card *card;
> + struct snd_card *card = NULL;
It's always a question how to "fix" such a problem.
The first option is to assign some "reasonable" value. Like your patch.
The second option is to use uninitialized_var().
The last option is to ignore it. It's gcc to blame.
I don't mind too much about such a trivial thing, so I just took your
> struct usb_device *device = interface_to_usbdev(intf);
> ret = create_card(device, intf, &card);
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
More information about the Alsa-devel