[alsa-devel] Confusing about Playback/Capture, CODEC/CODEC links, and snd_soc_dapm_link_dai_widgets()

[Liam Girdwood]

On Mon, 2012-06-04 at 15:02 +0200, Sebastien LEDUC wrote:
> Hi Liam
> There seem to be a similar mistake in the implementation of is_connected_output_ep / is_connected_input_ep:
> 
> In function is_connected_output_ep:
> -----------------------------------------------
> 
>  list_for_each_entry(path, &widget->sinks, list_source) {
>                 ...
>                 err = dapm_list_add_widget(list, path->sink);
>                 ...
> }
> 
> In function is_connected_input_ep:
> ---------------------------------------------
> 
> list_for_each_entry(path, &widget->sources, list_sink) {
> ...
>                 err = dapm_list_add_widget(list, path->sink);
> }
> 
> 
> I would have expected to have for the latter:
> err = dapm_list_add_widget(list, path->source);

Your right, this patch also got somehow dropped from squashing prior to
upstream. I'll send the fix shortly.

Thanks

Liam