[alsa-devel] [PATCH] ASoC: omap-mcbsp: Add pm_runtime_get/put functions call for McBSP.

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Jun 1 22:24:50 CEST 2012


On Fri, Jun 01, 2012 at 10:12:52PM +0200, Sebastien Guiriec wrote:
> pm_runtime_get_sync() and put_sync() are not called by McBSP driver.
> This is introducing a problem with PM and Audio Backend due to
> missing get/put for McBSP IP.

They are called by the core.  Probably you're just pointing your struct
device at some virtual device instead of the physical device, either
enabling runtime PM for the virtual device (assuming it's a child of the
physical device) or changing the pointer to the physical device (which
might make for better dev_ logging potentially) should resolve the
issue.

> +       pm_runtime_put_sync(mcbsp->dev);

No need for this, anyway - just use regular _put().  We don't care if
the device is actually suspended before we return, the PM core can do
that at it's leisure.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120601/51e50199/attachment-0001.sig 


More information about the Alsa-devel mailing list