[alsa-devel] [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
broonie at opensource.wolfsonmicro.com
Mon Jul 30 17:01:30 CEST 2012
On Mon, Jul 30, 2012 at 02:57:12PM +0100, Lee Jones wrote:
> On 30/07/12 14:39, Mark Brown wrote:
> >Why does the driver care - doesn't the pinctrl abstraction and/or
> >bindings handle this sensibly?
> Not when I tested it. pinctrl_get() came back !IS_ERR() for MSP0,
> MSP2 & MSP3, then when it went on to pinctrl_lookup_state(), only
> then did it fail. Would it be more sane to retract the error
> messages and just let it fail silently? It's either that or have
> lots of "could not get MSP defstate" clogging up the log.
This sounds to me like we should be ensuring that there's a single
fixed state available for these MSPs (representing the fact that the
pins are always in the right mode) in the pinctrl bindings.
As with several of other changes for this platform it seems like we need
to think carefully about the abstraction level we're working at.
More information about the Alsa-devel