[alsa-devel] [PATCH 06/21] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

Lee Jones lee.jones at linaro.org
Thu Jul 26 12:28:39 CEST 2012

If a list of widgets is provided and one of them fails to be added as
a control, the present semantics fail all subsequent widgets. A better
solution would be to only fail that widget, but pursue in attempting
to add the rest of the list.

Signed-off-by: Lee Jones <lee.jones at linaro.org>
 sound/soc/soc-dapm.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index eded657..7d9c154 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3095,8 +3095,6 @@ int snd_soc_dapm_new_controls(struct snd_soc_dapm_context *dapm,
 				"ASoC: Failed to create DAPM control %s\n",
-			ret = -ENOMEM;
-			break;

More information about the Alsa-devel mailing list