[alsa-devel] Crash when probing imx_mc13783

Fabio Estevam festevam at gmail.com
Thu Jul 26 19:16:43 CEST 2012


Hi Lee,

On Thu, Jul 26, 2012 at 1:15 PM, Lee Jones <lee.jones at linaro.org> wrote:

> The patch is apparently not correct (although, I do see a place for it). The
> problem is that unless your code populates codec->control_data, SoC Core
> will assume you haven't set-up any I/O for yourself, even if you have. I'm

Thanks for the advice. I did the following:

diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c
index 6276e35..c8251af 100644
--- a/sound/soc/codecs/mc13783.c
+++ b/sound/soc/codecs/mc13783.c
@@ -581,6 +581,8 @@ static int mc13783_probe(struct snd_soc_codec *codec)
 {
 	struct mc13783_priv *priv = snd_soc_codec_get_drvdata(codec);

+	codec->control_data = priv;
+
 	mc13xxx_lock(priv->mc13xxx);

 	/* these are the reset values */

,and now audio can be probed again.

Will submit this patch shortly.

Thanks,

Fabio Estevam


More information about the Alsa-devel mailing list