[alsa-devel] [PATCH 20/21] ASoC: codecs: Enable AB8500 CODEC for Device Tree
broonie at opensource.wolfsonmicro.com
Thu Jul 26 16:28:26 CEST 2012
On Thu, Jul 26, 2012 at 03:00:17PM +0100, Lee Jones wrote:
> On 26/07/12 12:50, Mark Brown wrote:
> >Yet again no binding documentation....
> RFC. ;)
> I'll write the documentation when/if the properties are accepted.
No, write the documentation. It's way too much effort to reverse
engineer the bindings from the code.
> >>+ default :
> >>+ codec->ear_cmv = EAR_CMV_UNKNOWN;
> >>+ dev_err(dev, "Unsuitable earpiece voltage found in DT\n");
> >The platform data code picks a default, can't the DT code do the same?
> No, I don't think that it does? The original code returns -EINVAL
> unless a value is specified.
The code doesn't specify values for the enumeration so it ought to
default to EAR_CMV_0_95V if nothing is specified.
> The original author is keen to have a clear error message in case
> users try to specify non-exact values. I'd rather we fail-out than
> use incorrect values which would be a great deal harder for a user
> to debug.
By that argument all the properties should be mandatory but it's only
this one IIRC.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel