[alsa-devel] [PATCH 2/2] ALSA: snd-usb: move calls to usb_set_interface
zonque at gmail.com
Fri Jul 13 08:08:26 CEST 2012
On 13.07.2012 07:58, Takashi Iwai wrote:
> At Thu, 12 Jul 2012 15:19:47 +0200,
> Daniel Mack wrote:
>> The rework of the snd-usb endpoint logic moved the calls to
>> snd_usb_set_interface() into the snd_usb_endpoint implemenation. This
>> changed the order in which these calls are issued to the device, and
>> thereby caused regressions for some webcams.
>> Fix this by moving the calls back to pcm.c for now to make it work again
>> and use snd_usb_endpoint_activate() to really tear down all remaining
>> URBs in the flight, consequently fixing another regression caused by USB
>> packets on the wire after altsetting 0 has been selected.
>> Signed-off-by: Daniel Mack <zonque at gmail.com>
>> Reported-and-tested-by: Philipp Dreimann <philipp at dreimann.net>
>> Reported-by: Joseph Salisbury <joseph.salisbury at canonical.com>
> Looks like the patch contains lots of coding-style issues.
> Could you fix what checkpatch.pl compains and resubmit?
Oops, sorry. Was working on a different machine for this, hence I didn't
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 0 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120713/2831be15/attachment-0001.patch
More information about the Alsa-devel