[alsa-devel] [PATCH V4 1/2] ASoC: STA529: Add support for STA529 Audio Codec

Rajeev kumar rajeev-dlh.kumar at st.com
Wed Jul 4 07:00:24 CEST 2012


Hello Mark,

On 7/4/2012 12:33 AM, Mark Brown wrote:
> On Tue, Jul 03, 2012 at 05:24:58PM +0530, Rajeev Kumar wrote:
>
>> +
>> +	/* set FFX audio frequency range */
>> +	val = (((val&  0x83) | (play_freq_val<<  4)) | (record_freq_val<<  2));
>> +	snd_soc_update_bits(codec, STA529_MISC, FREQ_RANGE_MSK, val);
>
> This is more buggy than last time, it's still setting both playback and
> record configuration but instead of using update_bits() like write()
> it's now using val uninitialised.  As I said last time it looks like you
> want to move this into the playback/capture if statement immediately above.




More information about the Alsa-devel mailing list