[alsa-devel] [PATCH] ASoC: dapm: Fix snd_soc_dapm_put_volsw() connect

[Takashi Iwai]

At Sat, 30 Jun 2012 19:24:47 +0100,
Mark Brown wrote:
> 
> On Sat, Jun 30, 2012 at 03:03:09PM +0200, Benoît Thébaudeau wrote:
> > On Sat, Jun 30, 2012 at 01:39:50PM +0200, Mark Brown wrote:
> 
> > > Actually I'd really expect it to mean exactly that.  DAPM is fairly
> > > fundamentally dealing with single channel audio streams and I'd expect
> > > that if we did implement stereo controls they'd allow these streams to
> > > pass through without getting merged.  There's a couple of things that
> > > stop us doing that right now but I don't think we should add stereo
> > > controls that don't do that.
> 
> > Can you be more specific about what stops us doing that right now?
> 
> Nothing if someone wants to implement it.
> 
> > Should we drop this idea for now and simply remove stereo from
> > snd_soc_dapm_get_volsw()?
> 
> It's going to be easier to remove the code if we're going to do anything
> at all, though there's no great urgency.

Then it'd be also better to put a sanity check to warn if
snd_soc_volsw_is_stereo() returns true.


Takashi