[alsa-devel] [RFC/PATCH] ASoC: dapm: Fix/add support for stereo widgets

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jul 2 14:27:14 CEST 2012

On Mon, Jul 02, 2012 at 01:46:42PM +0200, Benoît Thébaudeau wrote:
> This patch:
> * adds a choice in snd_soc_dapm_get_volsw_mut() for stereo between 1 and 2
>   registers, like in snd_soc_get_volsw().
> * fixes the missing stereo in other parts of dapm.
> * removes the unused saved_value from struct snd_soc_dapm_widget.

There's a couple of high level problems here.  

One is that you've got multiple different things in a single commit
which isn't great practice for review, especially with such a vauge

The other is that while you say that this "fixes the missing stereo in
other parts of dapm" I can't see any sign of any changes to (for
example) the path setup code which would seem to be essential for
supporting more than one channel in controls.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120702/918cc38e/attachment.sig 

More information about the Alsa-devel mailing list