[alsa-devel] [RFC][PATCH] ASoC: cs42l73: Fix Output [X|A|V]SP_SCLK Sourcing Mode setting for master mode

Brian Austin brian.austin at cirrus.com
Tue Jan 31 16:53:34 CET 2012


> For master mode, set Output [X|A|V]SP_SCLK Sourcing Mode to MCLK Mode.
>
> Signed-off-by: Axel Lin <axel.lin at gmail.com>
> ---
> Hi Brian,
> I think current code of setting priv->config[id].spc for master mode is wrong:
> priv->config[id].spc &= MCK_SCLK_64FS; will set priv->config[id].spc to be 0.
>
> I don't have this hardware, I'd appreciate you can review and test this patch.

Hey Axel,

Thanks for the catch.  Yes, for most normal slave operations where sclk = 
mclk you would set it the way you have it.

There is however another case where the SCLK = PREMCLK that puts 
constraints on the supported rates for the MCLK.  Your fix catches the 
majority of uses for Codec slave mode though.

Acked-by:Brian Austin <brian.austin at cirrus.com>





More information about the Alsa-devel mailing list