[alsa-devel] [PATCH] ALSA: Add #ifdef CONFIG_PCI guard for snd_pci_quirk_lookup* functions

[Takashi Iwai]

At Mon, 30 Jan 2012 14:03:30 +0800,
Axel Lin wrote:
> 
> This fixes below build warning when CONFIG_PCI is not set.
> 
> CC      sound/sound_core.o
> In file included from sound/sound_core.c:15:
> include/sound/core.h:454: warning: 'struct pci_dev' declared inside parameter list
> include/sound/core.h:454: warning: its scope is only this definition or declaration, which is probably not what you want
> 
> Signed-off-by: Axel Lin <axel.lin at gmail.com>
> ---
>  include/sound/core.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/sound/core.h b/include/sound/core.h
> index 5ab255f..fce4b6f 100644
> --- a/include/sound/core.h
> +++ b/include/sound/core.h
> @@ -450,11 +450,13 @@ struct snd_pci_quirk {
>  	{_SND_PCI_QUIRK_ID_MASK(vend, 0, 0), .value = (val)}
>  #endif
>  
> +#ifdef CONFIG_PCI

I'd begin the ifdef including the definition of struct snd_pci_quirk.
Could you revise the patch?


thanks,

Takashi