[alsa-devel] [PATCH] ALSA: HDA: Remove quirk for Asus N53Jq

[Takashi Iwai]

At Fri, 27 Jan 2012 14:31:19 +0100,
David Henningsson wrote:
> 
> The user reports that he needs to add model=auto for audio to
> work properly. In fact, since node 0x15 is not even a pin node,
> the existing fixup is definitely wrong. Relevant information can
> be found in the buglink below.
> 
> Cc: stable at kernel.org (3.2+)
> BugLink: https://bugs.launchpad.net/bugs/918254
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>

Thanks, applied now.

Looking at the bug, I guess we can remove all these fixups for ASUS
machines.  It was carried from the old code and I left the entries just
to be sure.  But any of them is actually buggy, it'd be better to
disable them.  You can see the "#if 1" around there, and it seems that
I decided to change from "#if 0" sometime later after writing the
comment there...


Takashi

> ---
>  sound/pci/hda/patch_realtek.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 0db1dc4..a7f17be 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5377,7 +5377,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1043, 0x8330, "ASUS Eeepc P703 P900A",
>  		      ALC269_FIXUP_AMIC),
>  	SND_PCI_QUIRK(0x1043, 0x1013, "ASUS N61Da", ALC269_FIXUP_AMIC),
> -	SND_PCI_QUIRK(0x1043, 0x1113, "ASUS N63Jn", ALC269_FIXUP_AMIC),
>  	SND_PCI_QUIRK(0x1043, 0x1143, "ASUS B53f", ALC269_FIXUP_AMIC),
>  	SND_PCI_QUIRK(0x1043, 0x1133, "ASUS UJ20ft", ALC269_FIXUP_AMIC),
>  	SND_PCI_QUIRK(0x1043, 0x1183, "ASUS K72DR", ALC269_FIXUP_AMIC),
> -- 
> 1.7.8.3
>