[alsa-devel] [PATCH 1/3] mfd: Add __devinit and __devexit annotations in wm8994

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jan 23 14:59:30 CET 2012

The wm8994_device_init() and wm8994_device_exit() functions were not
annotated as device init and exit functions, meaning they shouldn't
reference __devinitdata.

Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>

This is mostly just a warning fix for the second patch and doesn't seem
terribly critical otherwise so it should probably get merged along with

 drivers/mfd/wm8994-core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
index a04b3c1..a215b15 100644
--- a/drivers/mfd/wm8994-core.c
+++ b/drivers/mfd/wm8994-core.c
@@ -362,7 +362,7 @@ static int wm8994_ldo_in_use(struct wm8994_pdata *pdata, int ldo)
  * Instantiate the generic non-control parts of the device.
-static int wm8994_device_init(struct wm8994 *wm8994, int irq)
+static __devinit int wm8994_device_init(struct wm8994 *wm8994, int irq)
 	struct wm8994_pdata *pdata = wm8994->dev->platform_data;
 	struct regmap_config *regmap_config;
@@ -594,7 +594,7 @@ err_regmap:
 	return ret;
-static void wm8994_device_exit(struct wm8994 *wm8994)
+static __devexit void wm8994_device_exit(struct wm8994 *wm8994)

More information about the Alsa-devel mailing list