[alsa-devel] [PATCH 3/4] Revert "ASoC: omap-dmic: Use core to set the msbits constraint"

Peter Ujfalusi peter.ujfalusi at ti.com
Thu Jan 19 19:24:15 CET 2012


The core implementation applies the msbits constraint to samples
where it should not.
Do not ask core to do this, the original code does the right thing.

This reverts commit c50851684cf09444a77f59432f97bbdfb2617908.
---
 sound/soc/omap/omap-dmic.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
index 4dcb5a7..0855c1c 100644
--- a/sound/soc/omap/omap-dmic.c
+++ b/sound/soc/omap/omap-dmic.c
@@ -113,10 +113,12 @@ static int omap_dmic_dai_startup(struct snd_pcm_substream *substream,
 
 	mutex_lock(&dmic->mutex);
 
-	if (!dai->active)
+	if (!dai->active) {
+		snd_pcm_hw_constraint_msbits(substream->runtime, 0, 32, 24);
 		dmic->active = 1;
-	else
+	} else {
 		ret = -EBUSY;
+	}
 
 	mutex_unlock(&dmic->mutex);
 
@@ -443,7 +445,6 @@ static struct snd_soc_dai_driver omap_dmic_dai = {
 		.channels_max = 6,
 		.rates = SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_192000,
 		.formats = SNDRV_PCM_FMTBIT_S32_LE,
-		.sig_bits = 24,
 	},
 	.ops = &omap_dmic_dai_ops,
 };
-- 
1.7.8.3



More information about the Alsa-devel mailing list