[alsa-devel] [PATCH] ASoC: add driver for max9768 amplifier

[Mark Brown]

On Wed, Jan 18, 2012 at 08:33:20PM +0100, Wolfram Sang wrote:

> > Some documentation on what this does would be nice.  Is this something
> > that might usefully be changed at runtime?

> It only depends on the hardware design. Will a pointer to the section of the
> datasheet be enough for documentation?

Yes.

> > of DAPM support, even if it's just mapping out the pins.  Since you're
> > manually controlling the mute it'd be nice to make the unmute be (mute
> > && power) to save on pops and clicks from the CODEC being amplified.

> Sorry, not understood. Is there an example of what you mean here somewhere in
> the tree?

The WM2000 is doing something sort of similar, though it's quite a bit
more involved than just asserting a GPIO.

> > > +		err = gpio_request_one(pdata->mute_gpio, GPIOF_INIT_HIGH, "MAX9768 Mute");
> > > +		max9768->mute_gpio = err ?: pdata->mute_gpio;

> > I really don't like the ternery operator at the best of times...

> Can we agree to disagree? It is so convenient here and saves a few lines.

I'd rather not.