[alsa-devel] [PATCH v4 1/5] ASoC: Apply msbits constraint for sample size bigger than the msbits

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Jan 18 12:34:33 CET 2012

On Wed, Jan 18, 2012 at 12:18:22PM +0100, Peter Ujfalusi wrote:

> In order to avoid confusing the applications with msbits bigger
> than the selected sample size apply the msbits constraint only
> to sample seze bigger than the requested msbits.

>  	for (i = 0; i < ARRAY_SIZE(sample_sizes); i++) {
> +		if (sample_sizes[i] <= bits)
> +			break;

This isn't terribly legible and is the opposite test to the one in the
changelog.  A continue statement or a while loop would both be better.

More information about the Alsa-devel mailing list