[alsa-devel] [PATCH 1/2] ASoC: Allow drivers to specify how many bits are significant on a DAI

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Jan 17 12:38:49 CET 2012

On Tue, Jan 17, 2012 at 09:55:23AM +0100, Peter Ujfalusi wrote:

Peter, I shouldn't need to have to remind you to delete unneeded context
from your replies.

> Should we apply the constraint only if the sample size is bigger than
> the msbit request:
> 		if (sample_sizes[i] > bits) {
> 			ret = snd_pcm_hw_constraint_msbits();
> 		}

> Might be not an issue to say that we have 24msbit on the 8bit sample,
> but it does not sound right.

It shouldn't hurt and it is potentially useful to the application to
know that things will be converted up by the hardware; unless there's a
great reason to do so I'd rather not hide the information.

More information about the Alsa-devel mailing list