[alsa-devel] duplicated test in sound/soc/codecs/sgtl5000.c

Julia Lawall julia.lawall at lip6.fr
Thu Jan 12 22:13:24 CET 2012


There is a duplicated test in the function sgtl5000_restore_regs in the 
file sound/soc/codecs/sgtl5000.c:

                /* this regs depends on the others */
                 if (reg == SGTL5000_CHIP_ANA_POWER ||
                         reg == SGTL5000_CHIP_CLK_CTRL ||
                         reg == SGTL5000_CHIP_LINREG_CTRL ||
                         reg == SGTL5000_CHIP_LINE_OUT_CTRL ||
                         reg == SGTL5000_CHIP_CLK_CTRL)
                         continue;

I don't know if some constant other than SGTL5000_CHIP_CLK_CTRL should be 
tested, or if the second test should just be deleted.

julia


More information about the Alsa-devel mailing list