[alsa-devel] duplicated test in sound/soc/codecs/sgtl5000.c
B29396 at freescale.com
Fri Jan 13 07:21:00 CET 2012
> -----Original Message-----
> From: Mark Brown [mailto:broonie at opensource.wolfsonmicro.com]
> Sent: Friday, January 13, 2012 6:28 AM
> To: Julia Lawall; Fabio Estevam; Wolfram Sang; Dong Aisheng-B29396; Shawn Guo
> Cc: lrg at ti.com; alsa-devel at alsa-project.org
> Subject: Re: duplicated test in sound/soc/codecs/sgtl5000.c
> Importance: High
> On Thu, Jan 12, 2012 at 10:13:24PM +0100, Julia Lawall wrote:
> > There is a duplicated test in the function sgtl5000_restore_regs in
> > the file sound/soc/codecs/sgtl5000.c:
> > /* this regs depends on the others */
> > if (reg == SGTL5000_CHIP_ANA_POWER ||
> > reg == SGTL5000_CHIP_CLK_CTRL ||
> > reg == SGTL5000_CHIP_LINREG_CTRL ||
> > reg == SGTL5000_CHIP_LINE_OUT_CTRL ||
> > reg == SGTL5000_CHIP_CLK_CTRL)
> > continue;
> > I don't know if some constant other than SGTL5000_CHIP_CLK_CTRL should
> > be tested, or if the second test should just be deleted.
> Adding the people who've been working on the driver. Generally this is a good
> idea when reporting issues like this.
Looking at the code, I guess it's a typo error and the second check should be
SGTL5000_CHIP_REF_CTRL since it will restore it again.
Since zhaoming leaved Freescale a few month ago,
would you mind if I send a patch to add my name under MODULE_AHTOER as
Co-maintainer for this driver and update Zhaoming's email address?
More information about the Alsa-devel