[alsa-devel] [PATCH] snd-usb-us122l: Delete calls to preempt_disable

Takashi Iwai tiwai at suse.de
Mon Jan 9 11:32:03 CET 2012


At Fri, 30 Dec 2011 01:42:01 +0100,
Karsten Wiese wrote:
> 
> They are not needed here.
> 
> Signed-off-by: Karsten Wiese <fzu at wemgehoertderstaat.de>
> Cc: stable at kernel.org

Applied now.  Thanks.


Takashi


> ---
> 
> diff --git a/sound/usb/usx2y/usb_stream.c b/sound/usb/usx2y/usb_stream.c
> index 12ae034..dafcf79 100644
> --- a/sound/usb/usx2y/usb_stream.c
> +++ b/sound/usb/usx2y/usb_stream.c
> @@ -673,7 +673,7 @@ dotry:
>  		inurb->transfer_buffer_length =
>  			inurb->number_of_packets *
>  			inurb->iso_frame_desc[0].length;
> -		preempt_disable();
> +
>  		if (u == 0) {
>  			int now;
>  			struct usb_device *dev = inurb->dev;
> @@ -685,19 +685,17 @@ dotry:
>  		}
>  		err = usb_submit_urb(inurb, GFP_ATOMIC);
>  		if (err < 0) {
> -			preempt_enable();
>  			snd_printk(KERN_ERR"usb_submit_urb(sk->inurb[%i])"
>  				   " returned %i\n", u, err);
>  			return err;
>  		}
>  		err = usb_submit_urb(outurb, GFP_ATOMIC);
>  		if (err < 0) {
> -			preempt_enable();
>  			snd_printk(KERN_ERR"usb_submit_urb(sk->outurb[%i])"
>  				   " returned %i\n", u, err);
>  			return err;
>  		}
> -		preempt_enable();
> +
>  		if (inurb->start_frame != outurb->start_frame) {
>  			snd_printd(KERN_DEBUG
>  				   "u[%i] start_frames differ in:%u out:%u\n",
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 


More information about the Alsa-devel mailing list