[alsa-devel] [PATCH - ice1724 1/4] ALSA: ice1724 - Create capture pcm only for ADC-enabled configurations

Pavel Hofman pavel.hofman at ivitera.com
Mon Jan 9 10:48:11 CET 2012


Dne 9.1.2012 10:27, Takashi Iwai napsal(a):
> At Mon, 09 Jan 2012 08:36:54 +0100,
> Pavel Hofman wrote:
>>
>>
> 
> Ah, then I misunderstood your code.  The bit-wise operation is
> confusing for such a case.
> 
> It should be rather more easy-readable like:
> 
> 	if ((ice->eeprom.data[ICE_EEP2_SYSCONF] & VT1724_CFG_ADC_MASK) ==
> 	    VT1724_CFG_ADC_NONE)
> 		capt = 0;
> 	else
> 		capt = 1;
> 
> Could you revise the patch?
> 

Absolutely, happy to do so. Just please is there a way for me to
"migrate" from git.alsa-project.org to your repozitory at kernel.org
where the other patches were committed? I mean  without compiling the
whole kernel, just the drivers as with alsa-project.org? I followed the
description at
http://alsa-project.org/main/index.php/GIT_Server#Occasional_Developers
. The kmirror at git.alsa-project.org seems to be a bit behind.

Thanks a lot for help,

Pavel.


More information about the Alsa-devel mailing list