[alsa-devel] [PATCH] ASoC: introduce SOC_SINGLE_S8_TLV macro

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jan 9 09:28:09 CET 2012


On Mon, Jan 09, 2012 at 09:21:19AM +0100, Lars-Peter Clausen wrote:
> On 01/08/2012 09:23 PM, Mark Brown wrote:

> > Since no shifts are specified the signature is just the same as your
> > SOC_SINGLE_S8_TLV:

> There is a shift, but it is hard coded to 8 in snd_soc_get_volsw_s8, which
> isn't considered by the patch currently. So either SOC_DOUBLE_S8_TLV should
> initialize rshift to 8 or a shift and rshift parameter should be added. It

The second option seems better here.

> might also makes sense to add a shift parameter to SOC_SINGLE_S8_TLV as well.

Probably.


More information about the Alsa-devel mailing list