[alsa-devel] [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jan 9 05:15:46 CET 2012

On Mon, Jan 09, 2012 at 11:29:43AM +0800, Axel Lin wrote:
> This reverts commit 739be96ab83755e10fd0c2b6a34c8a73254527f7 because it 
> introduces below build warnings:

> drivers/misc/Kconfig:212:       symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
> sound/soc/atmel/Kconfig:9:      symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
> sound/soc/atmel/Kconfig:18:     symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC

>  	tristate
>  	depends on SND_ATMEL_SOC
> -	select ATMEL_SSC

Why is this the best fix?  It's not obvious to me that the dependency
from the machine driver to the ATMEL_SSC (rather than a select or
relying on the SSC driver sorting things out) is correct.

More information about the Alsa-devel mailing list