[alsa-devel] [PATCH 4/4] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Feb 23 18:14:07 CET 2012
On Thu, Feb 23, 2012 at 11:04:59AM -0600, Timur Tabi wrote:
> Russell King - ARM Linux wrote:
> > Is your readl() or readl_be() unordered then?
> Yes. At least, it sure looks like it is.
> > Wouldn't that be buggy
> > between coherent DMA accesses and accessing, eg, a PCI peripheral to
> > enable or read DMA status?
> I think so.
> We almost never use readl. I see that it is used in some places, but
> honestly I can't see how it can be valid. For instance, the mpic driver
> uses it in mpic_startup_ht_interrupt(). I don't understand how that's
> valid, since there's nothing preventing the readl() from happening
> *before* the writeb.
That just sounds broken. If readl() can happen before a writeb() issued
in program order, how do most of the PCI drivers work?
> I'll have to ask around, because I'm sure I'm missing something.
If what you say is true, it means we have different semantics for the
same accessors on different architectures. No wonder it's needing
drivers to gain ifdefs to select appropriate accessors.
This needs sorting out properly. It needs the semantics of readl() etc
to be fully defined, and all architectures to implement those semantics
rather than what they think would be appropriate for them.
More information about the Alsa-devel