[alsa-devel] FW: [PATCH v3] ASoC: Add support for TI LM49453 Audio codec
M R Swami Reddy
MR.Swami.Reddy at ti.com
Wed Feb 8 10:10:13 CET 2012
> -----Original Message-----
> From: Mark Brown [mailto:broonie at opensource.wolfsonmicro.com]
> Sent: Tuesday, February 07, 2012 10:34 PM
> To: Reddy, MR Swami
> Cc: Girdwood, Liam; alsa-devel at alsa-project.org
> Subject: Re: [PATCH v3] ASoC: Add support for TI LM49453 Audio codec
> On Mon, Feb 06, 2012 at 06:20:26AM -0800, Reddy, MR Swami wrote:
>> Changes made in v3:
>> o Updated the lm49453_set_dai_pll() as per review comments in v2 patch.
>> o Removed pll disable code in _set_dai_pll().
> This doesn't really seem to address the issue at all - you still have the problems with the set_pll() function not doing anything it's supposed to do with the input and output frequencies, and now there's no way to disable the PLL.
OK. So its ideal to remove the _set_dai_pll(), as its not doing anything here.
More information about the Alsa-devel