[alsa-devel] [PATCH] ASoC: core - Add support for DAI and machine kcontrols.

[Vinod Koul]

On Mon, 2012-02-06 at 14:26 +0000, Mark Brown wrote:
> On Mon, Feb 06, 2012 at 02:16:26PM +0000, Liam Girdwood wrote:
> > On Mon, 2012-02-06 at 13:27 +0000, Mark Brown wrote:
> > > On Mon, Feb 06, 2012 at 12:25:18PM +0000, Liam Girdwood wrote:
> 
> > > > sound/soc/mid-x86/mfld_machine.c:238:	ret_val = snd_soc_add_codec_controls(codec, mfld_snd_controls,
> 
> > > This looks bogus - looks like the missing fanout mux support which we
> > > should really fix properly.
> 
> > Vinod, fyi - something for your todo list ;-) 
> 
> Well, to be fair it's a feature missing in the core.
Hopefully I got the context right :)
So a machine driver should not add codec_controls but do a
card_controls, right?

While I can't disagree that these two controls are not properly done and
ought to be in the codec file and yes :) now they are now in my
ever-increasing todo list :(

-- 
~Vinod