[alsa-devel] [PATCH v2 6/9] ARM: mx31ads: add audmux device

[Richard Zhao]

Shawn Guo <shawn.guo at linaro.org> wrote:

>On Fri, Feb 03, 2012 at 10:15:54AM +0800, Richard Zhao wrote:
>> adding Eric Bénard.
>> 
>> On Thu, Feb 02, 2012 at 09:58:07PM +0800, Richard Zhao wrote:
>> > On Thu, Feb 02, 2012 at 09:09:03PM +0800, Shawn Guo wrote:
>> > > On Thu, Feb 02, 2012 at 05:24:28PM +0800, Richard Zhao wrote:
>> > > > On Thu, Feb 02, 2012 at 05:11:34PM +0800, Shawn Guo wrote:
>> > > > > On Thu, Feb 02, 2012 at 04:55:23PM +0800, Shawn Guo wrote:
>> > > > > > On Thu, Feb 02, 2012 at 10:12:05AM +0800, Richard Zhao
>wrote:
>> > > > > > > Signed-off-by: Richard Zhao <richard.zhao at linaro.org>
>> > > > > > > ---
>> > > > > > >  arch/arm/mach-imx/mach-mx31ads.c      |   10 ++++++++++
>> > > > > > >  arch/arm/plat-mxc/include/mach/mx31.h |    1 +
>> > > > > > >  2 files changed, 11 insertions(+), 0 deletions(-)
>> > > > > > > 
>> > > > > > Hmm, let's see who are actually using
>mxc_audmux_v2_configure_port().
>> > > > > > 
>> > > > > > $ git grep -n mxc_audmux_v2_configure_port arch/arm/
>> > > > > > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:246:    
>mxc_audmux_v2_configure_port(0,
>> > > > > > arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c:254:    
>mxc_audmux_v2_configure_port(4,
>> > > > > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c:257:    
>mxc_audmux_v2_configure_port(0,
>> > > > > > arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c:265:    
>mxc_audmux_v2_configure_port(3,
>> > > > > > arch/arm/mach-imx/mach-pcm043.c:365:   
>mxc_audmux_v2_configure_port(3,
>> > > > > > arch/arm/mach-imx/mach-pcm043.c:371:   
>mxc_audmux_v2_configure_port(0,
>> It's machine specific code, though audmux driver is common. Might be
>ok?
>
>With audmux driver moved out, it's not ok to me to have board file
>call this function.
>
>> The asoc machine file for the above 3 boards is not platform driver,
>and
>> don't get any plat info.
>
>It can be nicely solved if we do these initial setup in audmux driver
>probe function with the configuration data retrieved from audmux
>platform data or device tree.
no, it is asoc machine driver to have machine specific code. 
the machine driver do not correspond to any hw device, which cause hard to bind dt or create platform device.
>
>-- 
>Regards,
>Shawn
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel at lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel