[alsa-devel] [PATCH ] ASoC: Add support for TI LM49453 Audio codec

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Feb 3 14:55:45 CET 2012

On Fri, Feb 03, 2012 at 07:03:30PM +0530, M R Swami Reddy wrote:
> Mark Brown wrote:
> >On Fri, Feb 03, 2012 at 04:19:00AM -0800, Reddy, MR Swami wrote:

> >>Setting CHIP_EN bit as '0'. In the _STANDBY mode, CHIP_EN bit setting
> >>not needed and will remove in the next patch.

> >This also sounds broken, as I repeatedly said when reviewing previous
> >versions of the driver if disabling the chip does anything at all then
> >why don't you need to reenable the chip later?

> OK. I will remove chip disable code in case if _STANDBY and _OFF modes.

So the chip disable does nothing?  There's nothing wrong with disabling
the chip when it goes to idle, it's just that one would expect that
something ought to then reenable it when the device is needed again.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120203/65dd1a40/attachment-0001.sig 

More information about the Alsa-devel mailing list