[alsa-devel] [PATCH] ALSA: HDA: Fix jack creation for codecs with front and rear Line In
david.henningsson at canonical.com
Wed Feb 1 09:19:25 CET 2012
On 01/31/2012 04:40 PM, Takashi Iwai wrote:
> At Tue, 31 Jan 2012 16:28:14 +0100,
> David Henningsson wrote:
>> On 01/31/2012 03:17 PM, Takashi Iwai wrote:
>>> At Tue, 31 Jan 2012 09:04:15 +0100,
>>> David Henningsson wrote:
>>>> If a codec has both a front and a rear Line In, two controls both
>>>> named "Line Jack" will be created, which causes parsing to fail.
>>>> While a long term solution might be to name the jacks differently,
>>>> this extra check is consistent with what is already being done in many
>>>> auto-parsers, and will also protect against other cases when two
>>>> inputs have the same label.
>>>> BugLink: https://bugs.launchpad.net/bugs/923409
>>>> Signed-off-by: David Henningsson<david.henningsson at canonical.com>
>>> Thanks, applied now.
>>> BTW, any chance to change apport to gather alsa-info.sh output?
This has now been provided:
>>> It'd be a great help, so that we can check it via hda-emu.
>> I have asked for this particular bug reporter to supply alsa-info as
>> well, but may I ask you...do you have some kind of regression test
>> script, and if so, are they public? Or could it a part of hda-emu?
> The checks I often do are scripts like below. Run for all files
> and check the difference before and after the patch.
>> It would be nice if you could run "make tests" or something from the
>> hda-emu source directory, and it would parse all codecs and report error
>> if parsing fails (or pm fails, etc).
> Yeah, any patch is welcome ;)
Thanks for the small test scripts! It's good to be on the same page.
Hopefully I get around some day to write a "make tests", but not right
I quickly ran test2 and noticed that
- We have quite a lot of work to do before all errors are fixed!
- The error I got from hda-emu for the codec above, 'Control element
Line Jack:0 already exists!' was already present for one of the codecs.
David Henningsson, Canonical Ltd.
More information about the Alsa-devel