[alsa-devel] [PATCH 3/6] ASoC: Samsung-dma: Fix potential NULL pointer dereference

Mark Brown broonie at opensource.wolfsonmicro.com
Sun Dec 2 05:12:55 CET 2012

On Wed, Nov 21, 2012 at 02:36:56PM +0530, Sachin Kamat wrote:

>  static void audio_buffdone(void *data)
>  {
>  	struct snd_pcm_substream *substream = data;
> -	struct runtime_data *prtd = substream->runtime->private_data;
> +	struct runtime_data *prtd;

This should be a BUG_ON() or something rather than just a simple warning
- the checks here are redundant, there's no way we should ever end up
completing a buffer without an associated runtime.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20121202/745bdd71/attachment.sig>

More information about the Alsa-devel mailing list