[alsa-devel] [PATCH v2 2/4] ASoC: omap-mcbsp: Only print warning if the st_data is missing for the port

Peter Ujfalusi peter.ujfalusi at ti.com
Fri Aug 24 13:23:28 CEST 2012

On 08/24/2012 11:06 AM, Jarkko Nikula wrote:
> I acked the set but a little note here: I guess this is something what
> only developer can hit, by calling omap_mcbsp_st_add_controls for a port
> not having the sidetone, so would blocking the probe be better than warning?

I was hesitating when I did this patch but at the end only developers can hit
this - either trying to enable the ST on McBSP which does not physically have
ST block, or as of now booting their kernel with DT.
I'm rolling several patches for omap-twl4030 machine driver (support for McBSP
master configuration, ST support, etc). It is really annoying when you test a
change which is not ST related and when you boot with DT there is no card ->
so you need to modify the kernel between DT boot and non DT boot.

We have the warning about it, we do not add the ST controls but the audio
otherwise works.

The ST controls are not part of DAPM so the audio routing is not affected.

For us, developers it is better this way and for the users this does not
really matter.


More information about the Alsa-devel mailing list