[alsa-devel] [PATCH] ALSA: hda - Don't set invalid volume knob command on IDT 92hd75bxx

Takashi Iwai tiwai at suse.de
Thu Aug 16 14:06:53 CEST 2012


At Thu, 16 Aug 2012 13:53:05 +0200,
David Henningsson wrote:
> 
> @@ -5796,6 +5794,10 @@ again:
>  		break;
>  	}
>  
> +	if (codec->start_nid + codec->num_nodes >= 0x28 &&

Actually this should be ">"...

> +		get_wcaps_type(get_wcaps(codec, 0x28)) == AC_WID_VOL_KNB)

... but get_wcaps() already checks the NID range, and then
get_wcaps_type() return -1, thus the check above can be omitted.


Takashi


More information about the Alsa-devel mailing list