[alsa-devel] [PATCH] ALSA: hda - Fix 'Beep Playback Switch' with no underlying mute switch
david.henningsson at canonical.com
Tue Aug 14 09:02:38 CEST 2012
On 08/13/2012 05:39 PM, Takashi Iwai wrote:
> At Mon, 13 Aug 2012 17:30:13 +0200,
> David Henningsson wrote:
>> Some conexant devices has no mute capability on their Beep widgets.
>> This patch makes sure we don't try setting mutes on those widgets.
>> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
>> Another Beep fix. It's not that I'm suddenly obsessed with beeping; it's my automated
>> test tool that finds them :-)
> Good that you can demonstrate the results ;)
Yes, I'm still working on the test tool. Got to have something to show
at Plumber's :-)
>> I admit "knew->info == snd_hda_mixer_amp_switch_info" and "kctl->private_value = 0x10000"
>> looks a bit hacky, feel free to suggest something more elegant if you wish.
> Checking the amp out caps in snd_hda_mixer_amp_switch_*_beep() would
> be better, IMO. It's not necessarily limited to patch_conexant.c.
Ok, here comes a second version of the patch. What do you think?
David Henningsson, Canonical Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2968 bytes
Desc: not available
More information about the Alsa-devel