[alsa-devel] [PATCH v8] media: Add stk1160 new driver
Mauro Carvalho Chehab
mchehab at redhat.com
Thu Aug 9 22:25:50 CEST 2012
Patch looks ok. Just a few comments:
Em 06-08-2012 10:38, Ezequiel Garcia escreveu:
> This driver adds support for stk1160 usb bridge as used in some
> video/audio usb capture devices.
> It is a complete rewrite of staging/media/easycap driver and
> it's expected as a replacement.
Please don't add a "---" here. Everything after a --- are discarded
by my scripts (and by most other kernel developer scripts).
> Cc: Mauro Carvalho Chehab <mchehab at redhat.com>
> Cc: Takashi Iwai <tiwai at suse.de>
> Cc: Hans Verkuil <hverkuil at xs4all.nl>
> Cc: Sylwester Nawrocki <sylvester.nawrocki at gmail.com>
Hmm... weren't it reviewed already be them?
> Signed-off-by: Ezequiel Garcia <elezegarcia at gmail.com>
> diff --git a/drivers/media/video/stk1160/Makefile b/drivers/media/video/stk1160/Makefile
> new file mode 100644
> index 0000000..8f66a78
> --- /dev/null
> +++ b/drivers/media/video/stk1160/Makefile
> @@ -0,0 +1,12 @@
> +obj-stk1160-ac97-$(CONFIG_VIDEO_STK1160_AC97) := stk1160-ac97.o
> +stk1160-y := stk1160-core.o \
> + stk1160-v4l.o \
> + stk1160-video.o \
> + stk1160-i2c.o \
> + $(obj-stk1160-ac97-y)
> +obj-$(CONFIG_VIDEO_STK1160) += stk1160.o
> +ccflags-y += -Wall
You shouldn't be adding the above here.
> +ccflags-y += -Idrivers/media/video
Ah, please split this patch into two patches: one with the new driver
addition, and another one with the removal of the driver at staging.
That will help to make the patch smaller, and avoids mixing two different
things at the same place.
More information about the Alsa-devel