[alsa-devel] [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration

Peter Ujfalusi peter.ujfalusi at ti.com
Tue Aug 7 14:37:47 CEST 2012

The check for the mux_signal callback was wrong which prevents us to
configure the 6pin port's FSR/CLKR signal mux.

Reported-by: CF Adad <cfadad at rocketmail.com>
Cc: stable at kernel.org (3.4+)
Signed-off-by: Peter Ujfalusi <peter.ujfalusi at ti.com>

Hi Mark,

The omap-mcbsp FSR/CLKR mux configuration code seams to be broken since 3.4.
Would it be possible to apply this patch for the 3.6 release?

CC-ing stable at kernel.org since this part is broken in 3.4 and 3.5 kernels as


 sound/soc/omap/mcbsp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
index 1b08d98..5bda7c9 100644
--- a/sound/soc/omap/mcbsp.c
+++ b/sound/soc/omap/mcbsp.c
@@ -766,7 +766,7 @@ int omap_mcbsp_6pin_src_mux(struct omap_mcbsp *mcbsp, u8 mux)
 	const char *signal, *src;
-	if (mcbsp->pdata->mux_signal)
+	if (!mcbsp->pdata->mux_signal)
 		return -EINVAL;
 	switch (mux) {

More information about the Alsa-devel mailing list