[alsa-devel] [PATCH] ASoC: imx-ssi: Fix mono playback

[Fabio Estevam]

On Mon, Aug 6, 2012 at 6:49 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Mon, Aug 6, 2012 at 4:58 PM, Fabio Estevam <festevam at gmail.com> wrote:
>
>> Ok, understood.
>>
>> Sascha,
>>
>> Do you know if mono playback used to work previously in imx-ssi?
>
> Ok, just tested a mono track on a mx6qsabrelite and it played well.

Ops, I was making a confusion:

mx6sabrelite runs a dt kernel and uses fsl_ssi.c driver.

mx31pdk runs a non-dt kernel and uses imx-ssi.c driver.

The fsl_ssi.c code has:

	.playback = {
		/* The SSI does not support monaural audio. */
		.channels_min = 2,
		.channels_max = 2,
		.rates = FSLSSI_I2S_RATES,
		.formats = FSLSSI_I2S_FORMATS,
	},

and if I do the same on imx-ssi.c, ie, change 'channels_min' to 2,
then it also plays correctly.

So is my original patch correct? Maybe I should change the wording of
the commit log?

Thanks,

Fabio Estevam