[alsa-devel] [PATCH] Revert "ASoC: core: Try to use regmap if the driver doesn't set up any I/O"

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Aug 1 19:59:55 CEST 2012

On Wed, Aug 01, 2012 at 06:13:28PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > No, this isn't constructive - it just shoves things onto the drivers
> > that are relying on the implicit functionality.  Why not just change the
> > criteria we use to check, for example looking for the ops instead?

> Well, the NULL check of dev_get_regmap() looks necessary, but I find
> it was done in a wrong place in Peter's first patch, too.
> It could be rather in the caller side, e.g.

Yes, this is exactly the sort of change I'm talking about above.  We
need to take a better decision about deciding to use regmap for the
device I/O, this seems like a useful input.  Checking for ops should be
even better, though - one could potentially use regmap but want to wrap
it for some reason (can't think of one right now though).

What I *don't* think is a good idea is trying to bodge this in the I/O

More information about the Alsa-devel mailing list