[alsa-devel] [PATCH] ASoC: soc-io: Only force use regmap if the codec have it implemented

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Aug 1 15:24:20 CEST 2012

On Wed, Aug 01, 2012 at 04:09:30PM +0300, Peter Ujfalusi wrote:
> On 08/01/2012 03:40 PM, Mark Brown wrote:

> > You're changing the function setting up register I/O to ignore what's
> > being set.  This is silly - the soc-io code is doing exactly the right
> > thing here.

> Well, it overrides the codec->read/write/bulk_write_raw callbacks, sets the
> codec->using_regmap to true regardless if the codec have regmap or not.
> It should only do all of these if the regmap is there IMHO.

That's exactly what it's being asked to do!

> The soc-core calls snd_soc_codec_set_cache_io() if codec->control_data is NULL
> at the moment.

Right, so perhaps that's the decision which needs revisiting?

More information about the Alsa-devel mailing list