[alsa-devel] [PATCH] ASoC: soc-io: Only force use regmap if the codec have it implemented
broonie at opensource.wolfsonmicro.com
Wed Aug 1 14:40:21 CEST 2012
On Wed, Aug 01, 2012 at 03:20:29PM +0300, Peter Ujfalusi wrote:
> On 08/01/2012 03:16 PM, Mark Brown wrote:
> > On Wed, Aug 01, 2012 at 03:01:45PM +0300, Peter Ujfalusi wrote:
> >> case SND_SOC_REGMAP:
> >> /* Device has made its own regmap arrangements */
> >> - codec->using_regmap = true;
> > No, this is crazy.
> We set it when we have confirmed that the codec actually have regmap of it's own.
You're changing the function setting up register I/O to ignore what's
being set. This is silly - the soc-io code is doing exactly the right
thing here. Abstraction, folks.
More information about the Alsa-devel