[alsa-devel] [PATCH 2/8] ASoC: core: Add strobe control
broonie at opensource.wolfsonmicro.com
Mon Apr 23 21:13:02 CEST 2012
On Fri, Apr 20, 2012 at 11:32:44AM +0200, Ola Lilja wrote:
> From: Kristoffer KARLSSON <kristoffer.karlsson at stericsson.com>
> Added support for a control that strobes a bit in
> a register to high then back to low (or the inverse).
I've applied this but...
> + unsigned int val = snd_soc_read(codec, reg) & mask;
> + if (shift != 0 && val != 0)
> + val = val >> shift;
> + ucontrol->value.enumerated.item = val ^ invert;
...it seems weird that the code actually reads back the enumeration
status, even if we're in the middle of strobing it should be a very
brief, transitory, status which it isn't really worth going to the
effort of reporting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120423/787de48a/attachment.sig
More information about the Alsa-devel