[alsa-devel] [PATCH 1/7] Unify M-Audio Fast Track Ultra and Ebox-44 mixer quirks.

[Felix Homann]

Hi,

2012/4/23 Takashi Iwai <tiwai at suse.de>:
> At Mon, 23 Apr 2012 16:37:31 +0200,
> Felix Homann wrote:
>>
>> +     /* set TLV */
>> +     if (!tlv_callback) {
>
> I guess you want without !, no?

you're absolutely right.


>> +     snd_create_std_mono_ctl(mixer, 10, 2, 0x2, USB_MIXER_S16,
>> +                             "Input B Capture Volume", NULL);
>
> It would be safer to check the error of each call, but then it'd be
> better to make a table and loop over it.  You can create a new patch
> for that.

Please, tell Mark Hills. It's his patch you applied a couple of days
ago. I just renamed the functions and added the 'NULL' at the end of
the calls.

Regards,

Felix