[alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Apr 17 15:43:52 CEST 2012


On Tue, Apr 17, 2012 at 06:04:06PM +0530, Ashish Chavan wrote:

> +	/* Search pll div array for correct divisors */
> +	for (cnt = 0; cnt < ARRAY_SIZE(da7210_pll_div); cnt++) {
> +		/* check fref */
> +		if (fref == da7210_pll_div[cnt].fref) {
> +			/* check mode */
> +			 if (da7210->master ==  da7210_pll_div[cnt].mode) {
> +				/* check fout */
> +				if (fout == da7210_pll_div[cnt].fout) {

I've applied but this would be a lot clearer if it were writen as a
single if statement with &&s.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120417/509681f3/attachment.sig 


More information about the Alsa-devel mailing list