[alsa-devel] [PATCH 2/3] ALSA: usb: Fix fill_max flag set

Takashi Iwai tiwai at suse.de
Fri Apr 13 21:28:14 CEST 2012


ep->fill_max is a 1 bit flag, thus it has to be boolean.
  sound/usb/endpoint.c: In function 'snd_usb_endpoint_set_params':
  sound/usb/endpoint.c:785: warning: overflow in implicit constant conversion

Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
 sound/usb/endpoint.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index 8b695d5..12e5a95 100644
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -771,7 +771,7 @@ int snd_usb_endpoint_set_params(struct snd_usb_endpoint *ep,
 
 	ep->datainterval = fmt->datainterval;
 	ep->maxpacksize = fmt->maxpacksize;
-	ep->fill_max = fmt->attributes & UAC_EP_CS_ATTR_FILL_MAX;
+	ep->fill_max = !!(fmt->attributes & UAC_EP_CS_ATTR_FILL_MAX);
 
 	if (snd_usb_get_speed(ep->chip->dev) == USB_SPEED_FULL)
 		ep->freqn = get_usb_full_speed_rate(params_rate(hw_params));
-- 
1.7.9.2



More information about the Alsa-devel mailing list