[alsa-devel] [PATCH 1/2] ASoC: ac97: Fix build due to removal of 'runtime' definition
broonie at opensource.wolfsonmicro.com
Wed Apr 11 12:43:03 CEST 2012
On Tue, Apr 10, 2012 at 07:38:23PM -0300, Fabio Estevam wrote:
> This was caused by commit e6968a (ASoC: codecs: Remove rtd->codec usage from CODEC drivers),
> which removed the 'struct snd_pcm_runtime *runtime = substream->runtime' definition.
You're missing what I was saying the other day. What I was looking for
here was something more like "commit e6968a was intended to remove uses
of substream->runtime purely to find the CODEC pointer in order to
support CODEC<->CODEC links but in these cases we're actually using data
directly in the runtime so the removal shouldn't have been done here" -
the thing is to explain what the change did wrong and why this is a good
fix for that. Sometimes this is just that there was a typo but in cases
like this where the initial thought would be "why are we not removing
uses of runtime?" it makes it much easier to see why the fix is good.
It'd also have been good to just re-add the declaration of runtime here.
Anyway, applied both, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120411/aee8e2f2/attachment.sig
More information about the Alsa-devel